fix(metadata): operations must inherit from resource and defaults #5194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vincentchalamon
commented
Nov 16, 2022
vincentchalamon
commented
| Q | A |
|---|---|
| Branch? | 2.7 |
| Tickets | #5179 |
| License | MIT |
| Doc PR | N/A |
soyuka
reviewed
Nov 16, 2022
src/Metadata/Resource/Factory/ExtractorResourceMetadataCollectionFactory.php
Show resolved
Hide resolved
vincentchalamon
force-pushed
the
fix/issues/5179
branch
5 times, most recently
from
8121b60 to
736e2cc
Compare
vincentchalamon
force-pushed
the
fix/issues/5179
branch
from
736e2cc to
2b2d468
Compare
dunglas
reviewed
Nov 17, 2022
| @@ -26,6 +26,9 @@ | |||
| use ApiPlatform\Metadata\Put; | |||
| use ApiPlatform\Metadata\Resource\DeprecationMetadataTrait; | |||
| use ApiPlatform\Metadata\Resource\ResourceMetadataCollection; | |||
| use Psr\Log\LoggerInterface; | |||
| use Psr\Log\NullLogger; | |||
| use Symfony\Component\Serializer\NameConverter\CamelCaseToSnakeCaseNameConverter; | |||
There was a problem hiding this comment.
Can we find a way to remove this dependency? Or at least create an interface to abstract it?
There was a problem hiding this comment.
It should be done in a separate PR as it's used at least 7 times in traits and classes. It's hardcoded (new CamelCaseToSnakeCaseNameConverter()), using an interface would require a dependency injection behavior.
There was a problem hiding this comment.
I don't think there's a point doing an abstraction for this.
soyuka
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.