Skip to content

chore(ci): add php 8.2 on CI #5292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2022
Merged

chore(ci): add php 8.2 on CI #5292

merged 1 commit into from
Dec 30, 2022

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented Dec 27, 2022

Q A
Branch? 3.0.
Tickets #...
License MIT
Doc PR api-platform/docs#...

@@ -139,7 +139,7 @@ private function configureUriVariables(ApiResource|HttpOperation $operation): Ap
return $this->normalizeUriVariables($operation);
}

$hasUserConfiguredUriVariables = !($operation->getExtraProperties['is_legacy_resource_metadata'] ?? false);
$hasUserConfiguredUriVariables = !($operation->getExtraProperties()['is_legacy_resource_metadata'] ?? false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soyuka this is likely a bug in 2.7 too. And this should probably be review in 3.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR created for 2.7 branch #5294

@dunglas dunglas merged commit af98b64 into api-platform:3.0 Dec 30, 2022
@dunglas
Copy link
Member

dunglas commented Dec 30, 2022

Thanks!

@dannyvw dannyvw deleted the ci-php branch December 30, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants