-
-
Notifications
You must be signed in to change notification settings - Fork 901
feat: add context to XML parsing errors #5335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix code style on XmlResourceExtractor.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This should target 3.0 |
Not sure changing a message counts as a bug though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for targeting main
as it's not a bug IMHO
Co-authored-by: Alan Poulain <[email protected]>
Co-authored-by: Kévin Dunglas <[email protected]>
Thanks @yivi. |
Whenever an XML parsing error is found, the error message will be something like:
Which is terribly unhelpful. The only file mentioned is in this case is a general routes configuration file, which is absolutely unrelated to the issue at hand.
Yes, ideally one wouldn't be modifying several configuration files at the same time, but sometimes it does happen.
This commit simply adds the path where the error was found to the error message, so now it becomes:
Now the user knows the error happens on
SomeResource.xml
, and there is less frustration. :)