fix(jsonSchema): class shortname #5469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zowac
force-pushed
the
fix/shortname
branch
2 times, most recently
from
5fc1f51 to
0770472
Compare
Zowac
force-pushed
the
fix/shortname
branch
5 times, most recently
from
0358ab4 to
0127065
Compare
soyuka
reviewed
Mar 21, 2023
|
Can you squash your commits and rename: |
|
Thanks! |
|
Hi, This PR seems to have caused a regression in some cases of JsonSchema generation. I've created a minimal repro here: #5626 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5455 (comment)