fix(serializer): use data if no uri_variables provided #5743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
commented
Aug 11, 2023
| } | ||
|
|
||
| $uriVariables = $context['uri_variables']; | ||
| $uriVariables = $context['uri_variables'] ?? $data; |
There was a problem hiding this comment.
@Aerendir can you try this?
There was a problem hiding this comment.
Hi @soyuka , I've tried the fix, but it doesn't work...
In ItemNormalizer::getContextUriVariables(), there is no key $context['uri_variables'], so the variable $uriVariable gets the value of $data, but $data contains the entity and so there will never be the uri variables needed.
I'm going to reproduce in tests what's going on...
soyuka
commented
Aug 11, 2023
soyuka
commented
Aug 11, 2023
| } | ||
|
|
||
| return $context; | ||
| } |
There was a problem hiding this comment.
@jonag can you try this and use root_operation?
There was a problem hiding this comment.
Updating to API Platform v3.1.14 and changing my custom normalizer to use the root_operation instead of the operation fixes all my tests!
Thank you 👏!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5736