Skip to content

fix(serializer): retrieve only first uriVariable from operation #5788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

romainallanot
Copy link
Contributor

Q A
Branch? 3.1
Tickets #5736
License MIT
Doc PR N/A

@romainallanot romainallanot force-pushed the issue-5736 branch 2 times, most recently from e014697 to c0fa58b Compare August 30, 2023 13:17
@@ -189,69 +181,6 @@ public function testDenormalizeWithIri(): void
$this->assertInstanceOf(Dummy::class, $normalizer->denormalize(['id' => '/dummies/12', 'name' => 'hello'], Dummy::class, null, $context));
}

public function testDenormalizeGuessingUriVariables(): void
Copy link
Member

@soyuka soyuka Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong and can not work in a real case scenario so we remove it

@soyuka soyuka merged commit c7892a6 into api-platform:3.1 Sep 1, 2023
Romaixn pushed a commit to Romaixn/core that referenced this pull request Oct 3, 2023
…platform#5788)

* fix(serializer): retrieve only first uriVariable from operation

* array default

---------

Co-authored-by: Antoine Bluchet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants