-
-
Notifications
You must be signed in to change notification settings - Fork 900
feat(elasticsearch): filtering on nested fields #5835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
soyuka
merged 3 commits into
api-platform:main
from
jonnyeom:feat/filtering-on-nested-fields
Oct 17, 2023
Merged
feat(elasticsearch): filtering on nested fields #5835
soyuka
merged 3 commits into
api-platform:main
from
jonnyeom:feat/filtering-on-nested-fields
Oct 17, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can you fix phpunit tests on elasticsearch? to run them:
|
Yep. currently rethinking the approach. The resulting nested match query seems to be a bit different from what elasticsearch has documented It still works, im not sure if it is a hidden feature or a bug. So will confirm with them and proceed accordingly. |
1e2c257
to
7ea551d
Compare
soyuka
approved these changes
Oct 4, 2023
Great ! Thank you @jonnyeom |
Fr13nzzz
pushed a commit
to Fr13nzzz/api-platform-core-fork
that referenced
this pull request
Nov 23, 2023
* feat(elasticsearch): filtering on nested fields * Add additional checks and function doc for less confusion * Fixing tests
MariusJam
pushed a commit
to MariusJam/core
that referenced
this pull request
Nov 24, 2023
* feat(elasticsearch): filtering on nested fields * Add additional checks and function doc for less confusion * Fixing tests
soyuka
pushed a commit
to anoziere/core
that referenced
this pull request
Dec 18, 2023
* feat(elasticsearch): filtering on nested fields * Add additional checks and function doc for less confusion * Fixing tests
priyadi
pushed a commit
to priyadi/core
that referenced
this pull request
Jan 3, 2024
* feat(elasticsearch): filtering on nested fields * Add additional checks and function doc for less confusion * Fixing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets try again with added tests!
A better version of 5820, which was reverted
It is inline with elasticsearch's usage of nested documents
see elasticsearch nested docs
In the case of foo.bar.baz
bar
is an array of objects, we returnfoo.bar
.bar
is not an array, it does not qualify to be a nested property (according to elasticsearch) and we return null.This allows Filter and Match queries such as
GET /object-array-object-string/_search