feat: add webhook - openapi #5873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alli83
force-pushed
the
openapi-webhook
branch
3 times, most recently
from
235a006 to
2398d0e
Compare
alli83
commented
Oct 6, 2023
| @@ -227,9 +240,9 @@ private function collectPaths(ApiResource $resource, ResourceMetadataCollection | |||
| $openapiOperation = $openapiOperation->withDeprecated((bool) $operation->getOpenapiContext()['deprecated']); | |||
| } | |||
|
|
|||
| if ($path) { | |||
| if (!$pathItem && $path) { | |||
| $pathItem = $paths->getPath($path) ?: new PathItem(); | |||
There was a problem hiding this comment.
I will update: just $path should be enough
soyuka
reviewed
Oct 9, 2023
alli83
force-pushed
the
openapi-webhook
branch
from
2398d0e to
18fc9e5
Compare
|
Nice! Do you think we could add a functional test to |
soyuka
approved these changes
Oct 27, 2023
alli83
force-pushed
the
openapi-webhook
branch
2 times, most recently
from
d657fc4 to
89432a0
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
soyuka
reviewed
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible to configure a webhook via an attribute:
`
#[ApiResource(operations: [
]
)]`
and generate documentation