feat(graphql): partial pagination for page based pagination #6120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierleune
force-pushed
the
fix/hasnextpagepaginator-3
branch
3 times, most recently
from
5a3566e to
88909c1
Compare
xavierleune
changed the title
|
@soyuka hi, what do you think of this PR? |
|
it introduces interfaces therefore we should merge that to |
xavierleune
force-pushed
the
fix/hasnextpagepaginator-3
branch
from
88909c1 to
7ebfa6e
Compare
xavierleune
force-pushed
the
fix/hasnextpagepaginator-3
branch
from
7ebfa6e to
10bd773
Compare
|
@soyuka ok ! I rebased my branch against main and fixed the tests |
|
thanks @xavierleune ! |
xavierleune
added a commit
to xavierleune/docs
that referenced
this pull request
Feb 20, 2024
Document feature offered in api-platform/core#6120
soyuka
pushed a commit
to api-platform/docs
that referenced
this pull request
Feb 21, 2024
Document feature offered in api-platform/core#6120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests fixes the paginator to offer a partial pagination for page based pagination, as already stated in the documentation. This part seems to have been forgotten during initial implementation, so I suggest to merge it in the branch 3.2.