fix: reorder early return QueryParameterValidateListener #6300
Conversation
louismariegaborit
commented
Apr 8, 2024
louismariegaborit
commented
| Q | A |
|---|---|
| Branch? | main |
| Tickets | Closes #6243 |
| License | MIT |
| Doc PR |
| ]); | ||
|
|
||
| return; | ||
| } |
There was a problem hiding this comment.
can you add a non reg test in QueryParameterValidateListenerTest
There was a problem hiding this comment.
Tests added. I did some changes in addition on moved code.
Could you check if the if block stay good ?
There was a problem hiding this comment.
I have an error on CI that I don't have in my local env. I work on it this day.
There was a problem hiding this comment.
CI is ok.
The problem with phpunit tests was the namespace. I didn't see that test class was already exist in Symfony sources.
For my future contributions, why there are tests in ./tests/Symfony folder and others in ./src/Symfony/Tests ?
There was a problem hiding this comment.
We moved some tests into their components directory on the main branch, part of our subtree-split work. See: https://github.com/api-platform/core/blob/main/CONTRIBUTING.md#components-tests
louismariegaborit
force-pushed
the
fix_query_parameter_validate_listener
branch
5 times, most recently
from
03ee7fe to
28341f4
Compare
louismariegaborit
force-pushed
the
fix_query_parameter_validate_listener
branch
from
28341f4 to
86aaeb0
Compare
|
nice thanks! |
