fix(state): do not check content type if no input #6794
Conversation
alexndlm
force-pushed
the
feature/skip-content-negotiation-for-application-x-www-form-urlencoded-and-no-input
branch
from
46e9bcb to
ff39f5b
Compare
alexndlm
changed the title
|
|
||
| if (!$request->isMethodSafe() && 'DELETE' !== $request->getMethod()) { | ||
| throw new UnsupportedMediaTypeHttpException(\sprintf('The content-type "%s" is not supported. Supported MIME types are "%s".', $contentType, implode('", "', $supportedMimeTypes))); | ||
| } | ||
|
|
There was a problem hiding this comment.
Would it be possible to not set input formats in
https://github.com/api-platform/core/blob/3.4/src/Metadata/Resource/Factory/FormatsResourceMetadataCollectionFactory.php#L79
when deserialize is false? Or do you think that the problem should be handled here? In that case can you check https://gist.github.com/soyuka/beac00bc527d2ea6e703ed27dd67532c/revisions (first is with the suggested patch, the second if we can move the handling of the formats to FormatsResourceMetadataCollectionFactory instead as there's no point having input formats if we don't deserialize imo)
There was a problem hiding this comment.
We need to check if the operation has input in the ContentNegotiationProvider even if we do not set the input format in FormatsResourceMetadataCollectionFactory.
So, to avoid overcomplicating the code and possibly not introducing some bugs or BC, I prefer not to change the FormatsResourceMetadataCollectionFactory logic.
And I apply your suggestion.
Problem appears after #6102