Skip to content

Use Github actions instead of Travis CI (#278) #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

johnkrovitch
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tickets fixes #278
License MIT
Doc PR

Hi,

the goal of this PR is to move the CI from Travis CI to Github Actions. It aims to have the same behavior than Travis (#278).

Two worklows has been created :

  • ci.yaml : build the project, run the tests and the cs-fixer
  • release.yaml : upload the schema.phar asset when a new release is created

Note :

  • I am not sure why the php-cs-fixer and phpstan analye were only enabled for php 8.0, so it is now enabled for php 7.4 (but it can be easily reverted)

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this!! I made a few comments but it looks very promising.

@johnkrovitch johnkrovitch force-pushed the feature/change-to-github-actions-ci branch 6 times, most recently from 622100f to fa1432e Compare February 4, 2021 21:17
@johnkrovitch
Copy link
Contributor Author

Changes done. Do you want that the release workflow create the release or just upload release asset ?

@dunglas
Copy link
Member

dunglas commented Feb 4, 2021

If it can create the release when a tag is created it's even better

@johnkrovitch johnkrovitch force-pushed the feature/change-to-github-actions-ci branch from fa1432e to cbf35de Compare February 8, 2021 21:47
@johnkrovitch
Copy link
Contributor Author

The release workflow has been changed : it creates now a new release when a tag is pushed, and still upload release assets (schema.phar).

I'm not sure what to do about the changelog, should it be generated automatically or manually by a maintainer ?

@johnkrovitch johnkrovitch requested a review from dunglas March 19, 2021 18:34
@dunglas dunglas merged commit d54b6fd into api-platform:master Apr 29, 2021
@dunglas
Copy link
Member

dunglas commented Apr 29, 2021

Thanks @johnkrovitch! Regarding the changelog, we currently handle it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to GitHub Actions
2 participants