feat: support for gRPC stream APIs #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bisakhmondal
changed the title
4 tasks
bisakhmondal
force-pushed
the
stream_apis
branch
from
ed18b97 to
728072a
Compare
|
cc @spacewander for a review! Thanks |
spacewander
reviewed
Oct 21, 2021
main.go
Outdated
| @@ -115,6 +116,59 @@ func (s *server) Plus(ctx context.Context, in *pb.PlusRequest) (*pb.PlusReply, e | |||
| return &pb.PlusReply{Result: in.A + in.B}, nil | |||
| } | |||
|
|
|||
| // SayHelloMultiReply streams HelloReply back to the client. | |||
| func (s *server) SayHelloMultiReply(req *pb.HelloRequest, stream pb.Greeter_SayHelloMultiReplyServer) error { | |||
There was a problem hiding this comment.
Better to encode the stream type in the function name, so we don't need to add comment for them
spacewander
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the testing requirements of APISIX gRPC streaming proxy (issue apache/apisix#3601), this PR defines necessary gRPC streaming APIs as well as implements them.
Support includes: