Skip to content

feat: MCP implementation #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Dec 11, 2024
Merged

feat: MCP implementation #3

merged 17 commits into from
Dec 11, 2024

Conversation

jirispilka
Copy link
Collaborator

No description provided.

@jirispilka jirispilka requested a review from Copilot December 11, 2024 12:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 21 changed files in this pull request and generated 1 suggestion.

Files not reviewed (12)
  • .editorconfig: Language not supported
  • .env.example: Language not supported
  • .eslintrc: Language not supported
  • .python-version: Language not supported
  • LICENSE: Language not supported
  • Makefile: Language not supported
  • package.json: Language not supported
  • tsconfig.eslint.json: Language not supported
  • pyproject.toml: Evaluated as low risk
  • src/mcp_server_rag_web_browser/init.py: Evaluated as low risk
  • src/mcp_server_rag_web_browser/server.py: Evaluated as low risk
  • src/example_call_web_browser.ts: Evaluated as low risk
Comments skipped due to low confidence (4)

src/sse.ts:12

  • Ensure that the new SSE server behavior introduced in this route is covered by tests.
app.get('/sse', async (_req, res) => {

src/example_client_stdio.ts:49

  • The code should include more test cases to cover different queries and edge cases.
arguments: { query: 'web browser for Anthropic' }

src/server.ts:83

  • [nitpick] The error message for the missing APIFY_API_TOKEN is not user-friendly. Consider changing it to: 'APIFY_API_TOKEN is required but not set. Please set it in your environment variables or pass it as a command-line argument.'
throw new Error('APIFY_API_TOKEN environment variable is not set');

src/index.ts:5

  • Ensure that the server initialization and connection behavior introduced in this entry point is covered by tests.
async function main() {

@jirispilka jirispilka merged commit eded7a9 into main Dec 11, 2024
1 check passed
@jirispilka jirispilka deleted the feat/implementation branch December 11, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant