Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elixir fed2 support #119

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Elixir fed2 support #119

merged 1 commit into from
Jul 1, 2022

Conversation

kdawgwilk
Copy link
Contributor

@kdawgwilk kdawgwilk commented Jun 27, 2022 •
edited
Loading

Support for new fed2 directives 🎉

@kdawgwilk kdawgwilk mentioned this pull request Jun 27, 2022
Merged
@kdawgwilk kdawgwilk force-pushed the elixir_fed2 branch 3 times, most recently from c68b29e to dcffd66 Compare June 30, 2022 22:13
@kdawgwilk
Copy link
Contributor Author

New results summary 🎉

LibraryFederation 1 SupportFederation 2 Support
Absinthe.Federation
_service✅
`@key` (single)✅
`@key` (multi)✅
`@key` (composite)✅
`@requires`✅
`@provides`✅
`@ftv1`❌
`@link`✅
`@shareable`✅
`@tag`✅
`@override`✅
`@inaccessible`✅

@kdawgwilk kdawgwilk marked this pull request as ready for review June 30, 2022 22:18
@kdawgwilk
Copy link
Contributor Author

There is a workaround for not having a macro for the @link directive but we can fix that when this merges absinthe-graphql/absinthe#1176

@dariuszkuc dariuszkuc merged commit 85c520f into apollographql:main Jul 1, 2022
@kdawgwilk kdawgwilk deleted the elixir_fed2 branch July 1, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariuszkuc dariuszkuc dariuszkuc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdawgwilk @dariuszkuc