fix: bump kube-linter to version which supports more recent k8s apis #189
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ajpantuso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
+ Coverage 21.05% 21.13% +0.07%
==========================================
Files 20 20
Lines 793 790 -3
==========================================
Hits 167 167
+ Misses 608 605 -3
Partials 18 18
|
Ajpantuso
force-pushed
the
apantuso/bump_kube-linter_version
branch
from
4477006 to
d1c4ef9
Compare
| @@ -196,8 +196,8 @@ func getManagerOptions(scheme *k8sruntime.Scheme, opts options) (manager.Options | |||
| HealthProbeBindAddress: opts.ProbeAddr, | |||
| MetricsBindAddress: "0", // disable controller-runtime managed prometheus endpoint | |||
| // disable caching of everything | |||
| ClientBuilder: &newUncachedClientBuilder{}, | |||
| Scheme: scheme, | |||
| NewClient: newClient, | |||
There was a problem hiding this comment.
interesting change 👍
it took a minute for me the get my mind around this change 😄 , ClientBuilder is deprecated.
cc @thetechnick (fyi)
|
/lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Summary
Bumps kube-linter to a commit which supports more recent k8s apis.