Restrict deploying DVO to clusters that are 4.11.10+ #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
|
Note that we shouldn't merge this until 4.11.10 is available, as even test clusters won't be able to upgrade to it. |
|
/unhold |
|
/lgtm |
|
/approve |
|
/assign @Ajpantuso |
npecka
approved these changes
Oct 31, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ajpantuso, cblecker, npecka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
- Coverage 21.05% 20.56% -0.50%
==========================================
Files 20 20
Lines 793 914 +121
==========================================
+ Hits 167 188 +21
- Misses 608 708 +100
Partials 18 18
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that clusters need to be 4.11.10+ to get DVO.