-
Notifications
You must be signed in to change notification settings - Fork 447
Add Sequence.firstNonNil(_:) #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2895485
Add Sequence.firstNonNil(of:) and associated tests
Qata 3a13c14
Rename First.swift to FirstTests.swift
Qata ff69eae
Address PR comments by adding guide and changing naming
Qata a9e2295
Address PR comments by changing name
Qata fa09d75
Update Guides/FirstNonNil.md
Qata 5a0feb4
Update Sources/Algorithms/FirstNonNil.swift
Qata File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
# First | ||
|
||
[[Source](https://github.com/apple/swift-algorithms/blob/main/Sources/Algorithms/First.swift) | | ||
[Tests](https://github.com/apple/swift-algorithms/blob/main/Tests/SwiftAlgorithmsTests/FirstTests.swift)] | ||
|
||
## `firstNonNil` | ||
|
||
Retrieves the first `.some` encountered while applying the given transform. | ||
|
||
This operation is available through the `firstNonNil(_:)` method on any sequence. | ||
|
||
```swift | ||
let value = ["A", "B", "10"].firstNonNil { Int($0) } | ||
// value == .some(10) | ||
// | ||
let noValue = ["A", "B", "C"].firstNonNil { Int($0) } | ||
// noValue == .none | ||
``` | ||
|
||
|
||
This method is analogous to `first(where:)` in how it only consumes values until | ||
a `.some` is found, unlike using lazy operators, which will load any sequence into a collection | ||
before evaluating its transforms lazily. | ||
|
||
### Detailed Design | ||
|
||
The `firstNonNil(_:)` method is added as an extension method on the `Sequence` | ||
protocol: | ||
|
||
```swift | ||
public extension Sequence { | ||
func firstNonNil<Result>(_ transform: (Element) throws -> Result?) | ||
rethrows -> Result? | ||
} | ||
|
||
``` | ||
|
||
#### Naming | ||
|
||
This method’s name was selected for its comprehensibility. | ||
|
||
#### Comparison with other languages | ||
|
||
**Scala**: Scala provides a `collectFirst` function that finds the first element | ||
in a collection for which a partial function is defined. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// This source file is part of the Swift Algorithms open source project | ||
// | ||
// Copyright (c) 2020 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
//===----------------------------------------------------------------------===// | ||
// firstNonNil(_:) | ||
//===----------------------------------------------------------------------===// | ||
|
||
public extension Sequence { | ||
/// Returns the first element in `self` that `transform` maps to a `.some`. | ||
func firstNonNil<Result>(_ transform: (Element) throws -> Result?) rethrows -> Result? { | ||
for value in self { | ||
if let value = try transform(value) { | ||
return value | ||
} | ||
} | ||
return nil | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// This source file is part of the Swift Algorithms open source project | ||
// | ||
// Copyright (c) 2020 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
import XCTest | ||
import Algorithms | ||
|
||
final class FirstTests: XCTestCase { | ||
func testFirstNonNil() { | ||
XCTAssertNil([].firstNonNil { $0 }) | ||
XCTAssertNil(["A", "B", "C"].firstNonNil { Int($0) }) | ||
XCTAssertNil(["A", "B", "C"].firstNonNil { _ in nil }) | ||
XCTAssertEqual(["A", "B", "10"].firstNonNil { Int($0) }, 10) | ||
XCTAssertEqual(["20", "B", "10"].firstNonNil { Int($0) }, 20) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this API isn't
first
, butfirstNonNil
, can we align the naming of documents and headings accordingly?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking that it was a general category of functions for which others might be added. I'll amend it.