Skip to content

Rename sortedPrefix methods #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 26, 2021
Merged

Rename sortedPrefix methods #77

merged 7 commits into from
Feb 26, 2021

Conversation

natecook1000
Copy link
Member

@natecook1000 natecook1000 commented Feb 16, 2021 •
edited
Loading

This will update the sortedPrefix methods to prepare for the next release.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@natecook1000
Rename sortedPrefix to min(count:), add max(count:)
41db437
@natecook1000
Upcrease the documentation
6bcded3
@natecook1000
Rename SortedPrefix files
fc5b242
@natecook1000
Move min(count:) and max(count:) down to Sequence
9ec8b4d 
In order to still provide the optimization when `count` is close to
a collection's length, we include a Collection-specific overload of
all methods. These won't be accessed when in a Sequence-generic context,
but it's the best we can do without adding these methods as protocol
requirements.
@natecook1000 natecook1000 changed the title Rename sortedPrefix and slidingWindows methods Rename sortedPrefix methods Feb 17, 2021
@natecook1000 natecook1000 mentioned this pull request Feb 18, 2021
Closed
6 tasks
@natecook1000 natecook1000 marked this pull request as ready for review February 25, 2021 20:02
@natecook1000 natecook1000 merged commit bd64bef into main Feb 26, 2021
@natecook1000 natecook1000 deleted the nate/renamings branch February 26, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwu xwu xwu left review comments

@timvermeulen timvermeulen timvermeulen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natecook1000 @xwu @timvermeulen