Skip to content

Use nanosecondsSinceEpoch in SpanEvent #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
slashmo opened this issue Apr 12, 2023 · 0 comments · Fixed by #118
Closed

Use nanosecondsSinceEpoch in SpanEvent #117

slashmo opened this issue Apr 12, 2023 · 0 comments · Fixed by #118
Assignees
@slashmo
Milestone
1.0.0-beta.2

Comments

@slashmo
Copy link
Collaborator

slashmo commented Apr 12, 2023

In #114 we added nanosecondsSinceEpoch to the TracerInstant. SpanEvent, however, still uses millisecondsSinceEpoch.
We should also base SpanEvent on nanoseconds, exposing the same convenience millisecondsSinceEpoch accessor we do with TracerInstant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slashmo slashmo

Labels
None yet
Projects
None yet
Milestone
1.0.0-beta.2
Development

Successfully merging a pull request may close this issue.

Add nanoseconds to SpanEvent
1 participant
@slashmo