Add nanoseconds to instant protocol #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also resolves #103 by removing unused protocol |
ktoso
force-pushed
the
wip-addnanoseconds
branch
from
56b1e5c to
343a700
Compare
stevapple
reviewed
Mar 31, 2023
Sources/Tracing/TracingTime.swift
Outdated
| public static func /= (_ lhs: inout Self, _ rhs: Int) { | ||
| lhs = lhs / rhs | ||
| } | ||
| public protocol TracerInstantProtocol: Comparable, Hashable, Sendable { |
There was a problem hiding this comment.
This is one of the two last places where we have the Protocol suffix. Do we want to get rid of it entirely?
There was a problem hiding this comment.
Yeah I think we can 👍
I'll do this in this PR actually. Implementations tend to be called Timestamp or something like that after all
ktoso
force-pushed
the
wip-addnanoseconds
branch
from
d861a22 to
4f63ee9
Compare
Lukasa
approved these changes
Mar 31, 2023
fabianfett
approved these changes
Mar 31, 2023
ktoso
force-pushed
the
wip-addnanoseconds
branch
from
a09547a to
4f63ee9
Compare
**Motivation:** we have nanoseconds precision on most platforms so lets expose it.
**Motivation:** We're aggresively removing the Protocol suffixes **Result:** cleaner API
ktoso
force-pushed
the
wip-addnanoseconds
branch
from
4f63ee9 to
15ba1cf
Compare
slashmo
approved these changes
Apr 3, 2023
|
Sweet, thanks folks; moving on then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
we have nanoseconds precision on most platforms so lets expose it.
resolves #105