Skip to content

Span should be marked as Sendable #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabianfett opened this issue Jan 27, 2023 · 2 comments · Fixed by #83
Closed

Span should be marked as Sendable #79

fabianfett opened this issue Jan 27, 2023 · 2 comments · Fixed by #83
Assignees
@ktoso

Comments

@fabianfett
Copy link
Member

I'm pretty sure we want to allow Spans to be passed around. For this reason we should require them to be Sendable.
@ktoso
Copy link
Member

ktoso commented Jan 30, 2023

Agreed, will do

@ktoso
Copy link
Member

ktoso commented Jan 30, 2023

Tbh a lot of the types should be Sendable, even Injector and friends probably too.

@ktoso ktoso mentioned this issue Jan 30, 2023
Merged
@ktoso ktoso self-assigned this Jan 31, 2023
@ktoso ktoso closed this as completed in #83 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ktoso ktoso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark types Sendable apple/swift-distributed-tracing
2 participants
@ktoso @fabianfett