Mark types Sendable #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-sendable
branch
4 times, most recently
from
8982b6c to
f335a11
Compare
slashmo
approved these changes
Jan 31, 2023
fabianfett
reviewed
Jan 31, 2023
Sources/Tracing/Span.swift
Outdated
| extension SpanAttributes: Sendable {} | ||
| extension SpanAttribute: @unchecked Sendable {} | ||
| extension SpanStatus: Sendable {} | ||
| extension SpanEvent: @unchecked Sendable {} // unchecked because of DispatchWallTime |
There was a problem hiding this comment.
Is DispatchWallTime used for locking?
There was a problem hiding this comment.
No, for the "wall time" time type. Swift's Clocks are missing functionality and we would have to require 5.7 so sadly it's a no go either way... Though I'm still looking into using Swift's clock types
There was a problem hiding this comment.
but why is it "unchecked because of DispatchWallTime"? Is DispatchWallTime not marked as Sendable? Shouldn't we use @preconcurrency in that case?
There was a problem hiding this comment.
Right, I just moved to that in e3c5bc1 (#83) :)
ktoso
force-pushed
the
wip-sendable
branch
4 times, most recently
from
6997271 to
c31a43f
Compare
|
Nailed it now, I think... Last look @fabianfett ? :) |
stevapple
reviewed
Jan 31, 2023
|
|
||
| #if compiler(>=5.6.0) | ||
| extension DynamicTracepointTestTracer: @unchecked Sendable {} // only intended for single threaded testing {} | ||
| extension DynamicTracepointTestTracer.TracepointSpan: @unchecked Sendable {} // only intended for single threaded testing {} |
There was a problem hiding this comment.
I suspect the {} suffix here is unnecessary?
stevapple
reviewed
Jan 31, 2023
|
|
||
| #if compiler(>=5.6.0) | ||
| extension TracedLockPrintlnTracer: Sendable {} | ||
| extension TracedLockPrintlnTracer.TracedLockPrintlnSpan: @unchecked Sendable {} // only intended for single threaded testing {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #79
cc @fabianfett