Skip to content

Use 1.0.0 service-context #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2023
Merged

Use 1.0.0 service-context #128

merged 1 commit into from
May 31, 2023

Conversation

ktoso
Copy link
Member

@ktoso ktoso commented May 31, 2023

Motivation:
1.0 release should use 1.0 dependencies

Modifications:

use 1.0 of service context

@ktoso ktoso added this to the 1.x milestone May 31, 2023
@ktoso ktoso requested review from tomerd, yim-lee and slashmo May 31, 2023 20:50
@ktoso
Copy link
Member Author

ktoso commented May 31, 2023

Thanks for double checking :)

tomerd
tomerd approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@ktoso ktoso merged commit f4adcda into main May 31, 2023
@ktoso ktoso deleted the wip-service-context branch May 31, 2023 20:51
@ktoso ktoso modified the milestones: 1.x, 1.0.0-beta.3 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomerd tomerd tomerd approved these changes

@yim-lee yim-lee yim-lee approved these changes

@slashmo slashmo Awaiting requested review from slashmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ktoso @tomerd @yim-lee