Remove platform requirement from Package.swift #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevapple
suggested changes
Jun 5, 2023
slashmo
approved these changes
Jun 6, 2023
ktoso
approved these changes
Jun 27, 2023
|
@swift-server-bot add to allowlist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the platform requirement from the Package.swift and replaces it with
@availablechecks throughout the library where they weren't already placed.I placed everything in the Benchmarks package inside a
DSLBenchmarksenum so I only needed to add one@available.These changes are required if Hummingbird is going to merge in its tracing middleware PR without making it a breaking change