-
Notifications
You must be signed in to change notification settings - Fork 36
Fix use of Swift 6 language mode #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think we should take your suggestion of updating to use |
f327dc8
to
0ee1e63
Compare
It's updated to use |
Yeah, I'm not wild about the deprecation being present when there is no alternative choice. |
I pushed a fix for this as well. |
@ktoso I think we need a review from you here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good, thank you very much!
Definitely agreed on #if guarding the deprecations as well, thank you for doing that
Thanks for the ping! Coming out of sick leave inbox was overwhelmed 😅 |
@swift-server-bot test this please |
docc plugin seems borked on 5.7? Seems weird 🤔 Need to investigate what's up |
Anything new here? |
Could this have been a temporary glitch? Should we perhaps run the test again? |
@swift-server-bot test this please |
Sorry I was traveling and only now catching up here, let's see what's up here |
@swift-server-bot test this please |
Thank you, I'll cut a 1.1.2 with this |
Adds a [email protected] to make sure the package is compiled for the Swift 6 language mode. This fixes the visibility of the new withSpan functions, gated by
#if swift(>=6.0)
.Not sure if this is the desired solution, but it currently works for us. Let me know if something else is required and I'll be happy to look into it.
Edit:
After digging in some more, I think it would be better to update all
#if swift(>=6.0)
conditionals to#if compiler(>=6.0)
. Would that be an acceptable solution?