Skip to content

DocC Setup #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 10, 2022
Merged

DocC Setup #63

merged 5 commits into from
Aug 10, 2022

Conversation

yim-lee
Copy link
Member

@yim-lee yim-lee commented Aug 10, 2022

No description provided.

@yim-lee yim-lee requested a review from ktoso August 10, 2022 06:39
Copy link
Member

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for splitting out the in depth guide, that looks good.

@stevapple
Copy link
Contributor

stevapple commented Aug 10, 2022

Something off topic around the in-depth guide: is it possible for us to support only Swift 5.5+ (with @TaskLocal) in the initial release, so that users don't have to carry a context: LoggingContext around everywhere?

@ktoso
Copy link
Member

ktoso commented Aug 10, 2022

LoggingContext will not be a thing in the 1.0 release.

These docs are just a port of what was there, don't worry about the wording too much

@yim-lee
Copy link
Member Author

yim-lee commented Aug 10, 2022

Thanks @ktoso @stevapple for reviewing. All comments addressed I believe. Merging.

@yim-lee yim-lee merged commit f0d6746 into apple:main Aug 10, 2022
@yim-lee yim-lee deleted the docc branch August 10, 2022 22:31
@ktoso
Copy link
Member

ktoso commented Aug 11, 2022

Thank @yim-lee, looking good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants