-
Notifications
You must be signed in to change notification settings - Fork 36
DocC Setup #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DocC Setup #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for splitting out the in depth guide, that looks good.
Something off topic around the in-depth guide: is it possible for us to support only Swift 5.5+ (with @TaskLocal) in the initial release, so that users don't have to carry a |
LoggingContext will not be a thing in the 1.0 release. These docs are just a port of what was there, don't worry about the wording too much |
Co-authored-by: YR Chen <[email protected]>
Thanks @ktoso @stevapple for reviewing. All comments addressed I believe. Merging. |
Thank @yim-lee, looking good! |
No description provided.