Abstract away time source: TracingTime #86
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-tracing-time
branch
from
3bc22a6 to
210abc6
Compare
ktoso
commented
Feb 2, 2023
| /// The `DispatchWallTime` at which this event occurred. | ||
| public let time: DispatchWallTime | ||
| /// The time at which this event occurred. | ||
| public let time: TracingTime |
There was a problem hiding this comment.
The important part here is that even if we deprecate Span creation with this type and move to Clock, it would not have to be breaking to Tracer implementations -- they can still work without rushing to a breaking change in time type
ktoso
commented
Feb 2, 2023
| public struct TracingTime: Sendable { | ||
| enum Repr { | ||
| case dispatchWallTime(DispatchWallTime) | ||
| } |
There was a problem hiding this comment.
potentially other Clock.Instants or other time sources here...
weissi
reviewed
Feb 2, 2023
| } | ||
| private var repr: Repr | ||
|
|
||
| private init(dispatchWallTime: DispatchWallTime) { |
There was a problem hiding this comment.
i attempted to hide away dispatch completely, debatable if we care to do so or not
|
replaced by #98 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a
TracingTimetype that hides the dispatch use for the time source.If we get a Clock that can do this, we can more easily move to using it in API, without breaking tracer implementations.
Kind of... Resolves #71