Recording an error may carry attributes #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-error-attrs
branch
from
3e69c53 to
f418abb
Compare
**Motivation:** It can be used to attach more information bout the error, like its stacktrace and similar information. This is also supported by the otel spec, so we're aligning closer with it here. **Modifications:** Change the recordError to accept optional span attributes **Result:** more powerful record error API
ktoso
force-pushed
the
wip-error-attrs
branch
from
f418abb to
387bf2f
Compare
slashmo
approved these changes
Feb 24, 2023
Comment on lines
+278
to
+283
| XCTAssertTrue(endedSpan != nil) | ||
| XCTAssertEqual(endedSpan!.recordedErrors.count, 1) | ||
| let error = endedSpan!.recordedErrors.first!.0 | ||
| XCTAssertEqual(error as! ExampleSpanError, errorToThrow) | ||
| let attrs = endedSpan!.recordedErrors.first!.1 | ||
| XCTAssertEqual(attrs, attrsForError) |
There was a problem hiding this comment.
Do we want to use XCTUnwrap here instead of the force unwraps?
There was a problem hiding this comment.
Meh, tbh I don't mind those !, thank you for the review!
Co-authored-by: Moritz Lang <[email protected]>
Co-authored-by: Moritz Lang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It can be used to attach more information bout the error, like its stacktrace and similar information.
This is also supported by the otel spec, so we're aligning closer with it here.
Modifications:
Change the recordError to accept optional span attributes
Result:
more powerful record error API
resolves #45