Provide explicit set/get to avoid SpanAttributeConvertible wrapping #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-no-existentials-no-crisis
branch
from
c2cf5d6 to
5ccec37
Compare
ktoso
force-pushed
the
wip-no-existentials-no-crisis
branch
from
5ccec37 to
85b7e6b
Compare
ktoso
force-pushed
the
wip-no-existentials-no-crisis
branch
from
85b7e6b to
32d886a
Compare
yim-lee
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
I think we can do without this file now that this project is Swift 5.6+?
There was a problem hiding this comment.
I was going to check :-) Yes I think so, right? I'll remove
**Motivation:** Provide more control and allow avoiding the existential SpanAtrributeConvertible access when using the subscript. **Modifications:** additional API to avoid the existential **Result:** There is a way to use the API completely avoiding existentials
ktoso
force-pushed
the
wip-no-existentials-no-crisis
branch
from
29129aa to
09f0f98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide explicit set/get to avoid SpanAttributeConvertible existential wrapping, to those who care about such overhead
Motivation:
Provide more control and allow avoiding the existential SpanAtrributeConvertible access when using the subscript.
Modifications:
additional API to avoid the existential
Result:
There is a way to use the API completely avoiding existentials
resolves #82