This repository was archived by the owner on Apr 2, 2020. It is now read-only.
Update Swift Set/Dictionary formatters in preparation of upcoming changes #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps supporting the old layouts for now.
|
@swift-ci test |
|
This PR keeps support for old layouts. This can be removed in a followup PR later. |
dcci
approved these changes
Sep 21, 2018
| @@ -65,6 +68,18 @@ DictionaryConfig::DictionaryConfig() | |||
| = ConstString("Swift._SwiftDeferredNSDictionary<"); | |||
| m_deferredBridgedStorage_demangledRegex | |||
| = ConstString("^Swift\\._SwiftDeferredNSDictionary<.+,.+>$"); | |||
|
|
|||
| // Legacy Swift 4.2 storage class names | |||
| m_legacy_nativeStorage_mangledRegex_ObjC = | |||
There was a problem hiding this comment.
Feel free to remove the old layout. swiftc and swift-lldb are revlocked so keeping around legacy is pointless for now.
There was a problem hiding this comment.
Cool, I will do that in a followup next week. (I kept support for the old stuff in case we need to temporarily take out the Set/Dictionary PR.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiftlang/swift#19213 will change the internal layout of Set/Dictionary. Prepare for this by adding lldb support for the new storage layouts.
Bonus change: fix the new synthetic children frontend so that enumerating all children takes linear time. (It was quadratic with the old formatters.)