update recent addition to 5.0 syntax #258
Conversation
motivation: support 5.0 clients changes: return value epxlicitly
There was a problem hiding this comment.
Lgtm, but there's a discussion to have here. During #238 the consensus was to drop 5.0 support, so that's what we did and documented in release notes, removed the CI etc. So if we want to retract that move we need to do so properly, rather than with an adhoc fix that will regress again without CI.
The summary is that the 5.0 compiler can't survive parsing a task local, even when #if-ed out. There's no workaround in the language. So we'd have to do an very involved tricky dance to make some test into a separate module, only include it in build in new package files and modify the generate Linux tests script to handle this -- I had done all that but everyone in the review had voted against supporting 5.0 at the cost of this complexity so we dropped it.
So... 5.0 isn't supported, as documented in 1.5 release and adhoc fixing it is not the right way -- either we revive the workarounds I did, or we stick to our decision to drop 5.0
|
@ktoso right I remember that discussion. it does mean we need to remove the |
|
Hah I see, we missed to remove the file, here's a PR to rectify that: #259 |
|
Superseded by #259 |
motivation: support 5.0 clients
changes: return value explicitly