Skip to content

Base64EncodedData initializer taking an array slice shouldn't have a label #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
czechboy0 opened this issue Nov 7, 2023 · 2 comments · Fixed by apple/swift-openapi-runtime#71
Closed

Base64EncodedData initializer taking an array slice shouldn't have a label #368

czechboy0 opened this issue Nov 7, 2023 · 2 comments · Fixed by apple/swift-openapi-runtime#71
Assignees
@PARAIPAN9
Labels
area/runtime Affects: the runtime library. kind/bug Feature doesn't work as expected.
Milestone
1.0

Comments

@czechboy0
Copy link
Contributor

Base64EncodedData initializer taking an array slice shouldn't have a label.

- public init(data: ArraySlice<UInt8>)
+ public init(_ data: ArraySlice<UInt8>)

API breaking, do for 1.0.
@czechboy0 czechboy0 added area/runtime Affects: the runtime library. kind/bug Feature doesn't work as expected. labels Nov 7, 2023
@czechboy0 czechboy0 added this to the 1.0 milestone Nov 7, 2023
@PARAIPAN9
Copy link
Contributor

Hi, I'd be happy to take on the task of making this change.

@czechboy0
Copy link
Contributor Author

Sure! If you could add the new one, but keep the existing one for now and mark it as deprecated, and we'll clean up the deprecated one for 1.0 later.

@PARAIPAN9 PARAIPAN9 mentioned this issue Nov 8, 2023
Merged
czechboy0 pushed a commit to apple/swift-openapi-runtime that referenced this issue Nov 9, 2023
@PARAIPAN9
Base64EncodedData initializer taking an array slice shouldn't have a …
9da9ad6 
…label (#71)

### Motivation

- Fixes
[#369](apple/swift-openapi-generator#368)

### Modifications

- Remove init label argument from Base64EncodedData

### Result

- The Base64EncodedData init will be called without the label.

### Test Plan

- Adjust some tests from Test_OpenAPIValue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PARAIPAN9 PARAIPAN9

Labels
area/runtime Affects: the runtime library. kind/bug Feature doesn't work as expected.
Projects
None yet
Milestone
1.0
2 participants
@czechboy0 @PARAIPAN9