Skip to content

Disable warnings-as-errors for nightlies #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions Sources/_OpenAPIGeneratorCore/GeneratorPipeline.swift
Original file line number Diff line number Diff line change
Expand Up @@ -103,21 +103,21 @@ func makeGeneratorPipeline(
config: Config,
diagnostics: any DiagnosticCollector
) -> GeneratorPipeline {
let filterDoc = { (doc: OpenAPI.Document) -> OpenAPI.Document in
guard let documentFilter = config.filter else { return doc }
let filteredDoc: OpenAPI.Document = try documentFilter.filter(doc)
return filteredDoc
}
let validateDoc = { (doc: OpenAPI.Document) -> OpenAPI.Document in
let validationDiagnostics = try validator(doc, config)
for diagnostic in validationDiagnostics { diagnostics.emit(diagnostic) }
return doc
}
return .init(
parseOpenAPIFileStage: .init(
preTransitionHooks: [],
transition: { input in try parser.parseOpenAPI(input, config: config, diagnostics: diagnostics) },
postTransitionHooks: [
{ document in
guard let documentFilter = config.filter else { return document }
return try documentFilter.filter(document)
},
{ doc in
let validationDiagnostics = try validator(doc, config)
for diagnostic in validationDiagnostics { diagnostics.emit(diagnostic) }
return doc
},
]
postTransitionHooks: [filterDoc, validateDoc]
),
translateOpenAPIToStructuredSwiftStage: .init(
preTransitionHooks: [],
Expand Down
3 changes: 2 additions & 1 deletion docker/docker-compose.2204.main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ services:
test:
image: *image
environment:
- WARN_AS_ERROR_ARG=-Xswiftc -warnings-as-errors
# Disable warnings as errors on nightlies as they are still in-development.
# - WARN_AS_ERROR_ARG=-Xswiftc -warnings-as-errors
- IMPORT_CHECK_ARG=--explicit-target-dependency-import-check error
- STRICT_CONCURRENCY_ARG=-Xswiftc -strict-concurrency=complete
shell:
Expand Down