-
Notifications
You must be signed in to change notification settings - Fork 129
Relax minimum macOS requirement to 10.15 #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax minimum macOS requirement to 10.15 #63
Conversation
@swift-server-bot add to allowlist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, please also update the README and Documentation.md with these new deployment versions.
Will do. Also noticed that the |
6e23c90
to
21874a0
Compare
#18) ### Motivation Reduce deployment target by 3 versions to gain more adoption. ### Modifications - Reduced deployment targets by 3 versions - Modified `Converter#renderedRequestPath` to support iOS 13 ### Result Deployment target will be reduced by 3 versions. ### Related issues - Related to apple/swift-openapi-generator#62 ### Related PRs - Paired with apple/swift-openapi-generator#63 --------- Co-authored-by: andrewelliott <> Co-authored-by: Honza Dvorsky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also bump the dependency on the runtime library to 0.1.3, which also has the reduced versions.
@czechboy0 Sure! Just for future PRs, is that something I should have had in there from the start? Since this one was paired with a runtime PR should I have known to increase the version number based on the |
Assuming you mean the bumping of the runtime dependency version, then you couldn't have done it from the start because we needed to publish the release first, so you didn't miss any steps :) It's masked because the dependency on the runtime is only consumed in a test target within the generator, but if it was consumed in a library or executable target then the CI would have failed. We're just wanting to make sure we do a coordinated rollout in this instance. As to whether you'll need to always bump the version of the runtime library: not really, it depends on the change. Thanks for your contribution! |
Motivation
Reduce deployment target by 3 versions to gain more adoption.
Modifications
client.Package.x
andserver.Package.x
files to reflect new deployment targetsResult
Deployment target will be reduced by 3 versions and documentation will reflect such changes.
Resolves
Related PRs