Skip to content

Relax minimum macOS requirement to 10.15 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

andrewse02
Copy link
Contributor

@andrewse02 andrewse02 commented Jun 12, 2023

Motivation

Reduce deployment target by 3 versions to gain more adoption.

Modifications

  • Reduced deployment targets by 3 versions
  • Modified client.Package.x and server.Package.x files to reflect new deployment targets
  • Modified documentation to reflect new deployment targets

Result

Deployment target will be reduced by 3 versions and documentation will reflect such changes.

Resolves

Related PRs

@czechboy0
Copy link
Contributor

@swift-server-bot add to allowlist

Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, please also update the README and Documentation.md with these new deployment versions.

@andrewse02
Copy link
Contributor Author

andrewse02 commented Jun 13, 2023

Will do. Also noticed that the client.Package.x and server.Package.x files' deployment targets can be reduced as well. Adding that too.

@andrewse02 andrewse02 force-pushed the ae/reduce-deployment-targets branch from 6e23c90 to 21874a0 Compare June 13, 2023 05:36
@andrewse02 andrewse02 requested a review from czechboy0 June 13, 2023 05:38
simonjbeaumont pushed a commit to apple/swift-openapi-runtime that referenced this pull request Jun 13, 2023
#18)

### Motivation

Reduce deployment target by 3 versions to gain more adoption.

### Modifications

- Reduced deployment targets by 3 versions
- Modified `Converter#renderedRequestPath` to support iOS 13

### Result

Deployment target will be reduced by 3 versions.

### Related issues

- Related to apple/swift-openapi-generator#62

### Related PRs

- Paired with apple/swift-openapi-generator#63

---------

Co-authored-by: andrewelliott <>
Co-authored-by: Honza Dvorsky <[email protected]>
Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also bump the dependency on the runtime library to 0.1.3, which also has the reduced versions.

@simonjbeaumont simonjbeaumont changed the title Reduce deployment targets by 3 versions Relax minimum macOS requirement to 10.15 Jun 13, 2023
@andrewse02
Copy link
Contributor Author

@czechboy0 Sure! Just for future PRs, is that something I should have had in there from the start? Since this one was paired with a runtime PR should I have known to increase the version number based on the semver/X label?

@simonjbeaumont
Copy link
Collaborator

Just for future PRs, is that something I should have had in there from the start? Since this one was paired with a runtime PR should I have known to increase the version number based on the semver/X label?

Assuming you mean the bumping of the runtime dependency version, then you couldn't have done it from the start because we needed to publish the release first, so you didn't miss any steps :)

It's masked because the dependency on the runtime is only consumed in a test target within the generator, but if it was consumed in a library or executable target then the CI would have failed.

We're just wanting to make sure we do a coordinated rollout in this instance.

As to whether you'll need to always bump the version of the runtime library: not really, it depends on the change.

Thanks for your contribution!

@simonjbeaumont simonjbeaumont merged commit f530c90 into apple:main Jun 13, 2023
@simonjbeaumont simonjbeaumont added the 🔨 semver/patch No public API change. label Jun 13, 2023
@andrewse02 andrewse02 deleted the ae/reduce-deployment-targets branch June 14, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support platform versions back to macOS 10.15, iOS 13.0, tvOS 13.0, and watchOS 6.0
3 participants