Skip to content

Correct variable name in ClientMiddleware reference documentation #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2023
Merged

Correct variable name in ClientMiddleware reference documentation #19

merged 2 commits into from
Jun 14, 2023

Conversation

sikevux
Copy link
Contributor

@sikevux sikevux commented Jun 14, 2023

Motivation

The example for ClientMiddleware doesn't compile

Modifications

Correct the variable name in ClientMiddleware

Result

The example can now compile

@sikevux
Correct variable name in ClientMiddleware example
7f62131 
This change corrects the variable name in the `ClientMiddleware` example.
With this the example can now compile.
@simonjbeaumont simonjbeaumont changed the title Correct variable name in ClientMiddleware example Correct variable name in ClientMiddleware reference documentation Jun 14, 2023
@simonjbeaumont simonjbeaumont added the semver/none No version bump required. label Jun 14, 2023
simonjbeaumont
simonjbeaumont approved these changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sikevux—nice catch!

@simonjbeaumont simonjbeaumont enabled auto-merge (squash) June 14, 2023 12:24
czechboy0
czechboy0 requested changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sikevux, just one small suggestion.

auto-merge was automatically disabled June 14, 2023 17:02

Head branch was pushed to by a user without write access

@sikevux sikevux requested a review from czechboy0 June 14, 2023 17:03
@simonjbeaumont simonjbeaumont enabled auto-merge (squash) June 14, 2023 19:35
czechboy0
czechboy0 approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@czechboy0
Copy link
Contributor

@swift-server-bot add to allowlist

@simonjbeaumont simonjbeaumont merged commit bec8d38 into apple:main Jun 14, 2023
@sikevux sikevux deleted the update-docs branch June 16, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjbeaumont simonjbeaumont simonjbeaumont approved these changes

@czechboy0 czechboy0 czechboy0 approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sikevux @czechboy0 @simonjbeaumont