-
Notifications
You must be signed in to change notification settings - Fork 49
Adopt explicit existential any #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please ignore API breakage, known to fail when making changes like this, but safe to land:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swift-server-bot test this please |
The changes to the code are good, but not adding the enforcement yet until apple/swift-openapi-generator#119 |
Ok Integration Test passes again. |
Rather than just disable it everywhere, let's enable it in just the Swift 5.9+ builds, by adding This way we won't regress. |
Motivation
As a follow-on to apple/swift-openapi-generator#99, let's also enable explicit existential any in the runtime library.
Modifications
Enabled the flag in Package.swift (for Swift 5.9 and newer) and updated all the usage sites.
Result
The codebase is closer to being ready for Swift 6.
Test Plan
Updated unit tests as well, all is passing locally.