Skip to content

Fix incorrect YAML for aggregated roles #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2023
Merged

Fix incorrect YAML for aggregated roles #14

merged 1 commit into from
Jun 13, 2023

Conversation

simu
Copy link
Member

@simu simu commented Jun 13, 2023

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@simu simu added the bug Something isn't working label Jun 13, 2023
@simu simu requested a review from a team as a code owner June 13, 2023 11:24
bastjan
bastjan approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry did not catch that in the review 🙈

@simu
Copy link
Member Author

simu commented Jun 13, 2023

sorry did not catch that in the review see_no_evil

Every time I think "yeah this is straightforward enough, I don't need to test this" I make dumb mistakes.

@simu simu merged commit 35cf176 into master Jun 13, 2023
@simu simu deleted the fix/aggregated-rbac branch June 13, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastjan bastjan bastjan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simu @bastjan