-
Notifications
You must be signed in to change notification settings - Fork 852
Fix crash during async prefetch #21709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jbajic
wants to merge
14
commits into
devel
Choose a base branch
from
bugfix/bts-2119
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goedderz
approved these changes
Apr 7, 2025
goedderz
reviewed
Apr 8, 2025
tests/js/client/aql/aql-optimizer-rule-async-prefetch-noncluster.js
Outdated
Show resolved
Hide resolved
tests/js/client/aql/aql-optimizer-rule-async-prefetch-noncluster.js
Outdated
Show resolved
Hide resolved
please rename this test to |
goedderz
reviewed
Apr 9, 2025
KVS85
pushed a commit
that referenced
this pull request
Apr 9, 2025
* Backport of #21709 * add cgroups v2 memory limit detection (#21660) * add cgroups v2 memory limit detection * Find own cgroup and fix bug in limit computation. * Fix path joining. --------- Co-authored-by: Max Neunhoeffer <[email protected]> --------- Co-authored-by: Jure Bajic <[email protected]> Co-authored-by: Wilfried Goesgens <[email protected]> Co-authored-by: Max Neunhoeffer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
The PR fixes a crash during async prefetch.
The crash happens when an async prefetch task remains in the schedule even after the query for which it was started was resolved. This causes access to the ExecutionBlock object which was already released.
Checklist
Related Information
(Please reference tickets / specification / other PRs etc)