Skip to content

Fix crash during async prefetch #21709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: devel
Choose a base branch
from
Open

Fix crash during async prefetch #21709

wants to merge 14 commits into from

Conversation

jbajic
Copy link
Contributor

@jbajic jbajic commented Apr 7, 2025

Scope & Purpose

The PR fixes a crash during async prefetch.

The crash happens when an async prefetch task remains in the schedule even after the query for which it was started was resolved. This causes access to the ExecutionBlock object which was already released.

  • 💩 Bugfix
  • 🍕 New feature
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 📖 CHANGELOG entry made
  • 📚 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.12.0: (Please link PR)
    • Backport for 3.11: (Please link PR)
    • Backport for 3.10: (Please link PR)

Related Information

(Please reference tickets / specification / other PRs etc)

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket: BTS-2119
  • Design document:

@jbajic jbajic self-assigned this Apr 7, 2025
@cla-bot cla-bot bot added the cla-signed label Apr 7, 2025
@jbajic jbajic requested a review from goedderz April 7, 2025 08:33
@dothebart
Copy link
Contributor

please rename this test to ...-fp.js: tests/js/client/aql/aql-optimizer-rule-async-prefetch-noncluster.js so it can be filtered out in environments without failurepoinst.

goedderz pushed a commit that referenced this pull request Apr 9, 2025
KVS85 pushed a commit that referenced this pull request Apr 9, 2025
* Backport of #21709

* add cgroups v2 memory limit detection (#21660)

* add cgroups v2 memory limit detection
* Find own cgroup and fix bug in limit computation.
* Fix path joining.

---------

Co-authored-by: Max Neunhoeffer <[email protected]>

---------

Co-authored-by: Jure Bajic <[email protected]>
Co-authored-by: Wilfried Goesgens <[email protected]>
Co-authored-by: Max Neunhoeffer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants