Add exponential backoff for Slack requests #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbourd
force-pushed
the
add-backoff
branch
4 times, most recently
from
434a297 to
4504531
Compare
Adds a 30 second retry to POST requests made to Slack's API, in the event that Slack experiences an intermittent failure.
|
Is 30 seconds too long? We should be expect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a 30 second retry to POST requests made to Slack's API, in the event that Slack experiences an intermittent failure.
Closes #94
This does not retry locally on http requests to Concourse itself (for build data,
fixed/broketype). Not sure if we'd want to add that there as well, perhaps with a shorter back off?