-
Notifications
You must be signed in to change notification settings - Fork 81
CloudSchedule #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudSchedule #284
Conversation
4b24351
to
fe1a8bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pennam 👋 ☕ Can I ask you to add a example sketch show-casing how to actually use that property? From looking at the source code I don't really get it 😕
@aentinger sure! |
Hi @aentinger, i've added a simple sketch just to show how the cloud schedule property can be used. To define a schedule 4 field needs to be provided:
|
Regarding the msk value i think i can easily add some function to ease creation of scheduler configs. Not sure what to do with frm and to fields... 🤔 |
9a644fc
to
a0c01b0
Compare
a0c01b0
to
f148400
Compare
Hi @aentinger, I still need to fix UnitTests after the last changes, in the meanwhile do you mind having a look to the new example and functions to ease Schedule configuration ? 32292b5 also add support for timezone changes from the cloud. Thanks |
08cc475
to
c9e4315
Compare
rebased on master and squashed some commits to cleanup history |
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
==========================================
+ Coverage 95.31% 95.40% +0.08%
==========================================
Files 25 26 +1
Lines 896 1022 +126
==========================================
+ Hits 854 975 +121
- Misses 42 47 +5
Continue to review full report at Codecov.
|
cadfb98
to
d3d1fda
Compare
…e private varibles in constructor
… more clear how the time is configured
rebased and squashed some commits to cleanup history before merging. |
Memory usage change @ fda11b5
Click for full report table
Click for full report CSV
|
Opening to start integration testing with cloud side.
/cc @eclipse1985
TODO:
Add property testsUse const instead of numbersCheck CloudSchedule isActive() methodTimezone -> see https://github.com/pennam/ArduinoIoTCloud/tree/cloudschedule_timezone