Skip to content

UNO R4 WiFi fix warnings #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2024
Merged

UNO R4 WiFi fix warnings #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be59d24
OTA: UNO R4 WiFi fix magic number
pennam Jun 25, 2024
605e16b
UNO R4 WiFi suppress unused variable warning
pennam Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/ota/OTA.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ using ArduinoCloudOTA = ESP32OTACloudProcess;
#include "implementation/OTAUnoR4.h"
using ArduinoCloudOTA = UNOR4OTACloudProcess;

// TODO Check if a macro already exist
constexpr uint32_t OtaMagicNumber = 0x234110020; // TODO check this value is correct
constexpr uint32_t OtaMagicNumber = 0x23411002;

#else
#error "This Board doesn't support OTA"
Expand Down
1 change: 1 addition & 0 deletions src/tls/utility/TLSClientMqtt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ void TLSClientMqtt::begin(ConnectionHandler & connection) {
* also present in older firmware revisions
* https://github.com/arduino/uno-r4-wifi-usb-bridge/blob/f09ca94fdcab845b8368d4435fdac9f6999d21d2/certificates/certificates.pem#L852
*/
(void)connection;
#elif defined(ARDUINO_ARCH_ESP32)
setCACertBundle(x509_crt_bundle);
#elif defined(ARDUINO_ARCH_ESP8266)
Expand Down
1 change: 1 addition & 0 deletions src/tls/utility/TLSClientOta.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ void TLSClientOta::begin(ConnectionHandler &connection) {
/* AWS Root CAs are configured in uno-r4-wifi-usb-bridge/libraries/Arduino_ESP32_OTA
* https://github.com/arduino-libraries/Arduino_ESP32_OTA/blob/fc755e7d1d3946232107e2590662ee08d6ccdec4/src/tls/amazon_root_ca.h
*/
(void)connection;
#elif defined(ARDUINO_ARCH_ESP32)
setCACertBundle(x509_crt_bundle);
#elif defined(ARDUINO_ARCH_ESP8266)
Expand Down
Loading