Update libmodbus #128

facchinm · 2023-10-23T15:11:47Z

No description provided.

While handling MODBUS_FC_WRITE_AND_READ_REGISTERS, both address offsets must be checked, i.e. the read and the write address must be within the mapping range. At the moment, only the read address was considered, it looks like a simple copy and paste error, so let's fix it. Signed-off-by: Michael Heimpold <[email protected]>

This patch was contributed by Maor Vermucht and Or Peles from VDOO Connected Trust.

CLAassistant · 2023-10-23T15:11:55Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ stephane
❌ mhei
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

github-actions · 2023-10-23T15:24:29Z

Memory usage change @ e19543e

Board	flash	%	RAM for global variables	%
`arduino:mbed_nano:nano33ble`	🔺 0 - +64	0.0 - +0.01	0 - 0	0.0 - 0.0
`arduino:mbed_opta:opta`	🔺 0 - +64	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A
`arduino:megaavr:uno2018:mode=off`	🔺 0 - +62	0.0 - +0.13	0 - 0	0.0 - 0.0
`arduino:samd:mkrwifi1010`	🔺 +16 - +24	+0.01 - +0.01	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/RTU/ModbusRTUClientKitchenSink` flash	%	`examples/RTU/ModbusRTUClientKitchenSink` RAM for global variables	%	`examples/RTU/ModbusRTUClientParameters` flash	%	`examples/RTU/ModbusRTUClientParameters` RAM for global variables	%	`examples/RTU/ModbusRTUClientToggle` flash	%	`examples/RTU/ModbusRTUClientToggle` RAM for global variables	%	`examples/RTU/ModbusRTUServerKitchenSink` flash	%	`examples/RTU/ModbusRTUServerKitchenSink` RAM for global variables	%	`examples/RTU/ModbusRTUServerLED` flash	%	`examples/RTU/ModbusRTUServerLED` RAM for global variables	%	`examples/RTU/ModbusRTUTemperatureSensor` flash	%	`examples/RTU/ModbusRTUTemperatureSensor` RAM for global variables	%	`examples/TCP/EthernetModbusClientToggle` flash	%	`examples/TCP/EthernetModbusClientToggle` RAM for global variables	%	`examples/TCP/EthernetModbusServerLED` flash	%	`examples/TCP/EthernetModbusServerLED` RAM for global variables	%	`examples/TCP/WiFiModbusClientToggle` flash	%	`examples/TCP/WiFiModbusClientToggle` RAM for global variables	%	`examples/TCP/WiFiModbusServerLED` flash	%	`examples/TCP/WiFiModbusServerLED` RAM for global variables	%
`arduino:mbed_nano:nano33ble`	0	0.0	0	0.0	64	0.01	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	64	0.01	0	0.0	64	0.01	0	0.0
`arduino:mbed_opta:opta`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	64	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	64	0.0	0	0.0
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
`arduino:megaavr:uno2018:mode=off`	62	0.13	0	0.0	62	0.13	0	0.0	62	0.13	0	0.0	62	0.13	0	0.0	62	0.13	0	0.0	62	0.13	0	0.0	62	0.13	0	0.0	0	0.0	0	0.0	62	0.13	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwifi1010`	24	0.01	0	0.0	24	0.01	0	0.0	16	0.01	0	0.0	24	0.01	0	0.0	24	0.01	0	0.0	16	0.01	0	0.0	24	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0	16	0.01	0	0.0

Click for full report CSV

Board,examples/RTU/ModbusRTUClientKitchenSink<br>flash,%,examples/RTU/ModbusRTUClientKitchenSink<br>RAM for global variables,%,examples/RTU/ModbusRTUClientParameters<br>flash,%,examples/RTU/ModbusRTUClientParameters<br>RAM for global variables,%,examples/RTU/ModbusRTUClientToggle<br>flash,%,examples/RTU/ModbusRTUClientToggle<br>RAM for global variables,%,examples/RTU/ModbusRTUServerKitchenSink<br>flash,%,examples/RTU/ModbusRTUServerKitchenSink<br>RAM for global variables,%,examples/RTU/ModbusRTUServerLED<br>flash,%,examples/RTU/ModbusRTUServerLED<br>RAM for global variables,%,examples/RTU/ModbusRTUTemperatureSensor<br>flash,%,examples/RTU/ModbusRTUTemperatureSensor<br>RAM for global variables,%,examples/TCP/EthernetModbusClientToggle<br>flash,%,examples/TCP/EthernetModbusClientToggle<br>RAM for global variables,%,examples/TCP/EthernetModbusServerLED<br>flash,%,examples/TCP/EthernetModbusServerLED<br>RAM for global variables,%,examples/TCP/WiFiModbusClientToggle<br>flash,%,examples/TCP/WiFiModbusClientToggle<br>RAM for global variables,%,examples/TCP/WiFiModbusServerLED<br>flash,%,examples/TCP/WiFiModbusServerLED<br>RAM for global variables,%
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,64,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0
arduino:mbed_opta:opta,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,,,,,
arduino:megaavr:uno2018:mode=off,62,0.13,0,0.0,62,0.13,0,0.0,62,0.13,0,0.0,62,0.13,0,0.0,62,0.13,0,0.0,62,0.13,0,0.0,62,0.13,0,0.0,0,0.0,0,0.0,62,0.13,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,24,0.01,0,0.0,24,0.01,0,0.0,16,0.01,0,0.0,24,0.01,0,0.0,24,0.01,0,0.0,16,0.01,0,0.0,24,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0

mhei and others added 2 commits October 9, 2023 18:42

Fix VD-1301 and VD-1302 vulnerabilities

e19543e

This patch was contributed by Maor Vermucht and Or Peles from VDOO Connected Trust.

facchinm requested a review from stevisco October 23, 2023 15:19

facchinm merged commit d6eaa36 into arduino-libraries:master Oct 27, 2023

per1234 added the type: imperfection Perceived defect in any part of project label Oct 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update libmodbus #128

Update libmodbus #128

facchinm commented Oct 23, 2023

CLAassistant commented Oct 23, 2023

github-actions bot commented Oct 23, 2023

Update libmodbus #128

Update libmodbus #128

Conversation

facchinm commented Oct 23, 2023

CLAassistant commented Oct 23, 2023

github-actions bot commented Oct 23, 2023