Skip to content

ADC driver fixes. #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 21, 2023
Merged

ADC driver fixes. #52

merged 3 commits into from
Dec 21, 2023

Conversation

iabdalkader
Copy link
Collaborator

Fixes issue #51

@iabdalkader
AdvancedADC: Disable DMA IRQ before enabling double buffer mode.
178f327 
Signed-off-by: iabdalkader <[email protected]>
@iabdalkader
HALConfig: Raise ADC/DAC DMA priority.
cd5fb74 
During testing I noticed mbed OS will preempt or block DMA irq for
too long, causing DMA errors. ADC/DAC DMA should have the highest
priority since we don't have control over mbed.

Signed-off-by: iabdalkader <[email protected]>
@iabdalkader iabdalkader mentioned this pull request Dec 19, 2023
Closed
@per1234 per1234 linked an issue Dec 19, 2023 that may be closed by this pull request
Sampling with very high frequencies did not work as expected. #51
Closed
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Dec 19, 2023
@github-actions GitHub Actions
Copy link

Memory usage change @ cd5fb74

Board flash % RAM for global variables %
arduino:mbed_giga:giga 🔺 0 - +64 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Advanced/ADC_Multi
flash		 % examples/Advanced/ADC_Multi
RAM for global variables		 % examples/Advanced/ADC_Multi_Channel
flash		 % examples/Advanced/ADC_Multi_Channel
RAM for global variables		 % examples/Advanced/ADC_Multi_Channel_Dynamic
flash		 % examples/Advanced/ADC_Multi_Channel_Dynamic
RAM for global variables		 % examples/Advanced/ADC_Multi_To_DAC
flash		 % examples/Advanced/ADC_Multi_To_DAC
RAM for global variables		 % examples/Advanced/ADC_Serial_Plotter
flash		 % examples/Advanced/ADC_Serial_Plotter
RAM for global variables		 % examples/Advanced/ADC_To_DAC
flash		 % examples/Advanced/ADC_To_DAC
RAM for global variables		 % examples/Advanced/DAC_One_Channel
flash		 % examples/Advanced/DAC_One_Channel
RAM for global variables		 % examples/Advanced/DAC_Sine_wave
flash		 % examples/Advanced/DAC_Sine_wave
RAM for global variables		 % examples/Advanced/DAC_Two_Channels
flash		 % examples/Advanced/DAC_Two_Channels
RAM for global variables		 % examples/Beginner/Audio_Playback
flash		 % examples/Beginner/Audio_Playback
RAM for global variables		 % examples/Beginner/Waveform_Generator
flash		 % examples/Beginner/Waveform_Generator
RAM for global variables		 %
arduino:mbed_giga:giga 0 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/Advanced/ADC_Multi<br>flash,%,examples/Advanced/ADC_Multi<br>RAM for global variables,%,examples/Advanced/ADC_Multi_Channel<br>flash,%,examples/Advanced/ADC_Multi_Channel<br>RAM for global variables,%,examples/Advanced/ADC_Multi_Channel_Dynamic<br>flash,%,examples/Advanced/ADC_Multi_Channel_Dynamic<br>RAM for global variables,%,examples/Advanced/ADC_Multi_To_DAC<br>flash,%,examples/Advanced/ADC_Multi_To_DAC<br>RAM for global variables,%,examples/Advanced/ADC_Serial_Plotter<br>flash,%,examples/Advanced/ADC_Serial_Plotter<br>RAM for global variables,%,examples/Advanced/ADC_To_DAC<br>flash,%,examples/Advanced/ADC_To_DAC<br>RAM for global variables,%,examples/Advanced/DAC_One_Channel<br>flash,%,examples/Advanced/DAC_One_Channel<br>RAM for global variables,%,examples/Advanced/DAC_Sine_wave<br>flash,%,examples/Advanced/DAC_Sine_wave<br>RAM for global variables,%,examples/Advanced/DAC_Two_Channels<br>flash,%,examples/Advanced/DAC_Two_Channels<br>RAM for global variables,%,examples/Beginner/Audio_Playback<br>flash,%,examples/Beginner/Audio_Playback<br>RAM for global variables,%,examples/Beginner/Waveform_Generator<br>flash,%,examples/Beginner/Waveform_Generator<br>RAM for global variables,%
arduino:mbed_giga:giga,0,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@github-actions GitHub Actions
Copy link

Memory usage change @ 434fd37

Board flash % RAM for global variables %
arduino:mbed_giga:giga 🔺 0 - +64 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Advanced/ADC_Multi
flash		 % examples/Advanced/ADC_Multi
RAM for global variables		 % examples/Advanced/ADC_Multi_Channel
flash		 % examples/Advanced/ADC_Multi_Channel
RAM for global variables		 % examples/Advanced/ADC_Multi_Channel_Dynamic
flash		 % examples/Advanced/ADC_Multi_Channel_Dynamic
RAM for global variables		 % examples/Advanced/ADC_Multi_To_DAC
flash		 % examples/Advanced/ADC_Multi_To_DAC
RAM for global variables		 % examples/Advanced/ADC_Serial_Plotter
flash		 % examples/Advanced/ADC_Serial_Plotter
RAM for global variables		 % examples/Advanced/ADC_To_DAC
flash		 % examples/Advanced/ADC_To_DAC
RAM for global variables		 % examples/Advanced/DAC_One_Channel
flash		 % examples/Advanced/DAC_One_Channel
RAM for global variables		 % examples/Advanced/DAC_Sine_wave
flash		 % examples/Advanced/DAC_Sine_wave
RAM for global variables		 % examples/Advanced/DAC_Two_Channels
flash		 % examples/Advanced/DAC_Two_Channels
RAM for global variables		 % examples/Beginner/Audio_Playback
flash		 % examples/Beginner/Audio_Playback
RAM for global variables		 % examples/Beginner/Waveform_Generator
flash		 % examples/Beginner/Waveform_Generator
RAM for global variables		 %
arduino:mbed_giga:giga 0 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/Advanced/ADC_Multi<br>flash,%,examples/Advanced/ADC_Multi<br>RAM for global variables,%,examples/Advanced/ADC_Multi_Channel<br>flash,%,examples/Advanced/ADC_Multi_Channel<br>RAM for global variables,%,examples/Advanced/ADC_Multi_Channel_Dynamic<br>flash,%,examples/Advanced/ADC_Multi_Channel_Dynamic<br>RAM for global variables,%,examples/Advanced/ADC_Multi_To_DAC<br>flash,%,examples/Advanced/ADC_Multi_To_DAC<br>RAM for global variables,%,examples/Advanced/ADC_Serial_Plotter<br>flash,%,examples/Advanced/ADC_Serial_Plotter<br>RAM for global variables,%,examples/Advanced/ADC_To_DAC<br>flash,%,examples/Advanced/ADC_To_DAC<br>RAM for global variables,%,examples/Advanced/DAC_One_Channel<br>flash,%,examples/Advanced/DAC_One_Channel<br>RAM for global variables,%,examples/Advanced/DAC_Sine_wave<br>flash,%,examples/Advanced/DAC_Sine_wave<br>RAM for global variables,%,examples/Advanced/DAC_Two_Channels<br>flash,%,examples/Advanced/DAC_Two_Channels<br>RAM for global variables,%,examples/Beginner/Audio_Playback<br>flash,%,examples/Beginner/Audio_Playback<br>RAM for global variables,%,examples/Beginner/Waveform_Generator<br>flash,%,examples/Beginner/Waveform_Generator<br>RAM for global variables,%
arduino:mbed_giga:giga,0,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@iabdalkader iabdalkader merged commit f7d081c into main Dec 21, 2023
@iabdalkader iabdalkader deleted the adc_dbm_fix branch December 21, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardocavagnis leonardocavagnis leonardocavagnis approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sampling with very high frequencies did not work as expected.
3 participants
@iabdalkader @leonardocavagnis @per1234