Avoid to unlock the Sim if already unlocked #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ 4d615ac
Click for full report table
Click for full report CSV |
per1234
added
type: imperfection
facchinm
requested changes
Jan 29, 2025
| return SimStatus::SIM_ANTITHEFT_LOCKED; | ||
| } else { | ||
| return SimStatus::SIM_ERROR; | ||
| } | ||
| } | ||
|
|
||
| bool ArduinoCellular::unlockSIM(String pin){ | ||
| if(this->debugStream != nullptr){ | ||
| this->debugStream->println("Unlocking SIM..."); | ||
| int simStatus = modem.getSimStatus(); |
There was a problem hiding this comment.
isn't this shadowing the global simStatus ?
There was a problem hiding this comment.
Sorry, I had an issue with visualization, everything is ok 🙂
facchinm
approved these changes
Jan 29, 2025
| return SimStatus::SIM_ANTITHEFT_LOCKED; | ||
| } else { | ||
| return SimStatus::SIM_ERROR; | ||
| } | ||
| } | ||
|
|
||
| bool ArduinoCellular::unlockSIM(String pin){ | ||
| if(this->debugStream != nullptr){ | ||
| this->debugStream->println("Unlocking SIM..."); | ||
| int simStatus = modem.getSimStatus(); |
There was a problem hiding this comment.
Sorry, I had an issue with visualization, everything is ok 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoid to try to unlock the SIM if the SIM is already unlocked.
If the SIM is unlocked and there is an attempt to unlock it (this happens in Arduino_ConnectionHandler in
update_handleInit()function) the modem return an error (at least in Opta Cellular device) and this prevent the connection to the network.So it seems sensible to avoid to unlock the SIM if the SIM is READY.
Also this PR introduces a change in the function
getSimStatus()in order to avoid to call multiple timemodem.getSimStatus()that involves useless communication with modem.