Make library configurable using defines #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facchinm
approved these changes
Mar 8, 2022
per1234
added
topic: code
aentinger
reviewed
Mar 8, 2022
| @@ -179,7 +179,7 @@ int Arduino_Portenta_OTA::decompress() | |||
|
|
|||
| feedWatchdog(); | |||
|
|
|||
| if (ota_header.header.magic_number != 0x2341025b) /* 0x2341:025b = VID/PID Portenta H7 */ | |||
| if (ota_header.header.magic_number != ARDUINO_PORTENTA_OTA_MAGIC) | |||
There was a problem hiding this comment.
Is there also a ARDUINO_PORTENTA_OTA_MAGIC for non H7 boards? This is confusing me 😉
There was a problem hiding this comment.
Hi @aentinger my intention should be more clear now -> #23
|
Memory usage change @ ad3d370
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the library will support other platforms i've added a configuration file where is possible to change:
In the future core releses we can add specific defines to configure the library removing board name
ARDUINO_PORTENTA_H7_M7dependency.By now the library name will remain the same, but we should think about renaming or deprecating this library and create a new one.