-
Notifications
You must be signed in to change notification settings - Fork 4
[RFC] Use raw queue elements #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also fixes @aentinger comment about return types
a7ffbb8
to
8696075
Compare
Thank you for all your effort @facchinm (and sorry for me continueing to bother you 😉 ). There's one last wish I'd like to voice: Replace the do-it-yourself heap allocation via #include "platform/SharedPtr.h"
/* ... */
rtos::Queue<SharedPtr<T>, 16> queue;
/* ... */
Shared<T> obj(new T(val));
return (*obj);
/* ... */ |
@aentinger can you provide a PR? I'm going to merge this one in the meantime 🙂 |
@facchinm Yes, that's probably a good idea 😆 I'll create an issue and assign it to myself. |
Fixes #2
@pnndra @aentinger