-
Notifications
You must be signed in to change notification settings - Fork 45
Fix hardReset method to match the datasheet #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Memory usage change @ 47c66f2
Click for full report table
Click for full report CSV
|
@janakelarsson @aentinger am I misinterpreting the datasheet? It says minimum 10s for low pulse to reset the modem using RESETN. 1 second, in my testing on my MKR NB 1500, does nothing to reset the modem. |
Thanks, I must have missed that somehow. In my case, 1 s was sufficient to reset the modem. |
@aentinger any thoughts around this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 10 seconds strike me as containing a high margin for safety but since the data seem to require such a long delay I'm good with this change.
After reviewing the code for the MKRNB library, I noticed the hardReset method is still incorrect when compared to the SARA-R410M-02B datasheet.
Ref: https://www.u-blox.com/sites/default/files/SARA-R4_DataSheet_%28UBX-16024152%29.pdf