Adding Validity-Checks for incoming packets #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Library with Wifi I experienced some problems with timestamps occasionally being way off, by that I mean more than 1,000,000,000 s off.
After some investigation I discovered that the board had captured some other UDP-Packets and had interpreted them as NTP-Packets. Somehow the application PowerFolder had sent them to Port 1337 of the board (why that is is another problem).
However I decided to implement a few validity checks before actually interpreting the packets as NTP-Packets. Feel free to edit my implementation. I implemented a method "isValid()" which gets called in "forceUpdate".