Replace unicode left/right quotes with normal quotes #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace double turned comma quotes (U+201C, U+201D) with programmer's double quotes (U+0022).
|
|
per1234
added
type: imperfection
per1234
approved these changes
Apr 18, 2022
There was a problem hiding this comment.
Thanks @markpatterson27! Those "fancy quotes" are the source of a lot of headaches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace double turned comma quotes (U+201C, U+201D) with programmer's double quotes (U+0022).
Some of the example code snippets use unicode fancy quotes instead of normal plain double quotes. This throws a compile error if the examples are copy/pasted into sketches.